Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: support for poetry metadata format 2.0 #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GabMus
Copy link

@GabMus GabMus commented Mar 11, 2023

No description provided.

@mig5
Copy link

mig5 commented May 29, 2023

Thank you for this! I applied this as a patch and it has solved the problem for me when running flatpak-poetry-generator.py against my poetry.lock after I upgraded poetry to version 1.5.0.

Copy link

@ENDrain ENDrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe could also add a line in README.md listing metadata formats supported, but not sure if that's necessary. @mig5, since this worked for you could you also please add an approving review?

@GabMus
Copy link
Author

GabMus commented Sep 23, 2023

I really think we should merge this

@d4nj1
Copy link

d4nj1 commented Jan 17, 2024

@hfiguiere
Copy link
Collaborator

Can you rebase this? We could get it merged eventually.

@uninstall-your-browser
Copy link

uninstall-your-browser commented Jun 2, 2024

--production does not seem to work, it still tries (and fails) to retrieve dev dependencies (unless I'm somehow generating my lock file wrong?). Though it should probably be changed to --without <group-name>, since poetry has deprecated --no-dev.

@hfiguiere
Copy link
Collaborator

@GabMus unless this gets rebased, this can't be merged.

@hfiguiere hfiguiere added the Need Rebase The PR need rebase before merging label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need Rebase The PR need rebase before merging poetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants