node: skip errors on optional dependencies #355

proletarius101 · 2023-04-09T14:30:41Z

e.g. In https://raw.githubusercontent.com/lensapp/lens/master/package-lock.json

    "node_modules/npm/node_modules/@colors/colors": {
      "version": "1.5.0",
      "inBundle": true,
      "license": "MIT",
      "optional": true,
      "engines": {
        "node": ">=0.1.90"
      }
    },

refi64 · 2023-04-10T01:38:34Z

node/flatpak_node_generator/providers/npm.py

@@ -134,6 +134,9 @@ def _process_packages_v2(
                        'Git sources in lockfile v2 format are not supported yet'
                        f' (package {install_path} in {lockfile})'
                    )
+            elif info.get('optional'):
+                # Optional dependencies can be skipped


Should this at least be printing out a warning? Not sure if we do that anywhere else in the source yet, but it could be useful if the user was actually expecting the optional dep to still make its way inside.

node: skip errors on optional dependencies

0ed6f64

refi64 reviewed Apr 10, 2023

View reviewed changes

hfiguiere added npm node labels Apr 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node: skip errors on optional dependencies #355

node: skip errors on optional dependencies #355

proletarius101 commented Apr 9, 2023

refi64 Apr 10, 2023

node: skip errors on optional dependencies #355

Are you sure you want to change the base?

node: skip errors on optional dependencies #355

Conversation

proletarius101 commented Apr 9, 2023

refi64 Apr 10, 2023

Choose a reason for hiding this comment