Use __ARM_ACLE to guard inclusion of arm_acle.h #2264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build FLINT v3.2.0 with julia's BinaryBuilder (to produce the julia package
FLINT_jll.jl
that is a dependency ofNemo.jl
), the build foraarch64-linux-gnu
failed with the following error message:(full log at https://buildkite.com/julialang/yggdrasil/builds/18605#01958cb4-1ad1-4dac-87ea-34869cf00fad/689-11246)
This could be due to BinaryBuilder.jl using very old compilers for maximum compatibility of produced libraries; the above error was produced with GCC v6.
#2245 added a check wether the
arm_acle.h
header contains therbit
instruction. However, it does not check if thearm_acle.h
header even exists in the first place.According to https://github.com/ARM-software/acle/releases/download/r2024Q4/acle-2024Q4.pdf, Section 3.5.1, one can test this by checking for
__ARM_ACLE
(as this PR does).Adding the patch from this PR to the BinaryBuilder.jl script fixed the above build failure, so I thought it would be good to upstream this.