feat: add RDS cluster parameter group actions#838
Merged
hectorvent merged 1 commit intoMay 15, 2026
Conversation
Implement the missing Aurora cluster parameter group APIs that the Pulumi/Terraform AWS provider invokes via aws.rds.ClusterParameterGroup: - CreateDBClusterParameterGroup - DescribeDBClusterParameterGroups - DeleteDBClusterParameterGroup - ModifyDBClusterParameterGroup - DescribeDBClusterParameters Storage and handler logic mirrors the existing instance-level parameter group implementation. Without these actions, any IaC stack that defines an Aurora ClusterParameterGroup fails with UnsupportedOperation and never reaches Aurora cluster creation. Tests cover the new XML envelope shape, required-field validation, service round-trip, duplicate rejection, and parameter modification.
hectorvent
approved these changes
May 15, 2026
Collaborator
|
Thanks @john-goloti Solid implementation. Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the five missing Aurora cluster parameter group APIs in the RDS Query handler:
CreateDBClusterParameterGroupDescribeDBClusterParameterGroupsDeleteDBClusterParameterGroupModifyDBClusterParameterGroupDescribeDBClusterParametersMotivation
Stacks defined with the Terraform/Pulumi AWS provider that declare an
aws_rds_cluster_parameter_group(or Pulumi'saws.rds.ClusterParameterGroup) currently fail against Floci with:This prevents Aurora cluster deployment from completing, since the cluster resource references the parameter group via
db_cluster_parameter_group_name. Floci already implements the instance-level parameter group APIs (CreateDBParameterGroupand friends); this PR adds the cluster-level counterparts that the AWS service model exposes as a parallel resource type.Implementation
DbClusterParameterGroup(mirrorsDbParameterGroup).RdsServicegains an in-memoryStorageBackend<String, DbClusterParameterGroup>and CRUD methods.RdsQueryHandlerdispatches the five new actions, writes the appropriate XML envelopes (<DBClusterParameterGroup>/<DBClusterParameterGroups>/<Parameters>), and matches the existing parameter-group code style.Tests
RdsServiceTest: round-trip, duplicate rejection, modify parameters, missing-name errors for delete/get.RdsQueryHandlerTest: tag-shape assertions, required-field validation for create/delete/describe, argument passthrough, parameter parsing that ignores entries with no value../mvnw test -Dtest='RdsServiceTest,RdsQueryHandlerTest'runs 31 tests, 0 failures.Verified against a real IaC deploy
The original blocker came from a Pulumi
infrastructure-applicationstack that declared:With Floci
1.5.15this errored before any Aurora resource was created. With this PR's branch built locally, the action succeeds andModifyDBClusterParameterGroupaccepts the four parameters above.Out of scope
Tagson parameter groups — neither the instance-level handler nor this one currently emits them in the response (kept consistent for now; can be a follow-up).Sourceattribute on individual parameters (engine-default/user) — emitted only asIsModifiable=truehere, same asDescribeDBParameters.