Relax Pure::Parser's comment regex to allow any characters in a multi-line comment #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex used by
Pure::Parser
for ignoring comments in JSON tries to do some fancy handling to prohibit nested comments, but it causes it to choke on strings that would otherwise be legit (i.e. that can be parsed byExt::Parser
or by a C compiler).For example, a couple strings that are parsed correctly by
Ext::Parser
but notPure::Parser
:This is the original regex (visualized by Regexper):
This is the simplified regex after my changes (Regexper):
I added a test to assert that a comment containing
/*
is parseable. Note that the test case immediately above that change asserts that a nested ANSI C-style comment still triggers an exception.