Skip to content

1892 replace php cs fixer and rector with mago linter formatter #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Draft

1892 replace php cs fixer and rector with mago linter formatter #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b38367
feature: mago initial configuration
norberttech Nov 9, 2025
506206c
fix: added path to phpunit to mago config
norberttech Nov 9, 2025
345c4eb
chore: updated mago to latest version
norberttech Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 0 additions & 161 deletions .php-cs-fixer.php
View file
Open in desktop

This file was deleted.

16 changes: 8 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@
"test:monorepo": "tools/monorepo/vendor/bin/monorepo-builder validate",
"static:analyze": [
"./tools/monorepo/vendor/bin/monorepo-builder validate",
"@static:analyze:cs-fixer",
"./tools/mago/vendor/bin/mago lint",
"./tools/mago/vendor/bin/mago fmt --dry-run",
"@static:analyze:phpstan",
"@static:analyze:rector"
],
Expand All @@ -422,13 +423,10 @@
"tools/rector/vendor/bin/rector -c ./rector.tests.php --dry-run",
"tools/rector/vendor/bin/rector -c ./rector.src.php --dry-run"
],
"static:analyze:cs-fixer": [
"tools/cs-fixer/vendor/bin/php-cs-fixer fix --dry-run"
],
"cs:php:fix": [
"tools/cs-fixer/vendor/bin/php-cs-fixer fix",
"./tools/rector/vendor/bin/rector -c ./rector.src.php",
"./tools/rector/vendor/bin/rector -c ./rector.tests.php"
"./tools/rector/vendor/bin/rector -c ./rector.tests.php",
"./tools/mago/vendor/bin/mago fmt"
],
"build:phar": [
"composer update --working-dir=./src/cli",
Expand Down Expand Up @@ -499,7 +497,8 @@
"composer install --working-dir=./tools/phpstan",
"composer install --working-dir=./tools/phpunit",
"composer install --working-dir=./tools/rector",
"composer install --working-dir=./tools/phpdocumentor"
"composer install --working-dir=./tools/phpdocumentor",
"composer install --working-dir=./tools/mago"
],
"tools:update": [
"composer update --working-dir=./tools/blackfire",
Expand All @@ -511,7 +510,8 @@
"composer update --working-dir=./tools/phpstan",
"composer update --working-dir=./tools/phpunit",
"composer update --working-dir=./tools/rector",
"composer update --working-dir=./tools/phpdocumentor"
"composer update --working-dir=./tools/phpdocumentor",
"composer update --working-dir=./tools/mago"
]
}
}
143 changes: 143 additions & 0 deletions mago.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
# Welcome to Mago!
# For full documentation, see https://mago.carthage.software/tools/overview
php-version = "8.2.0"

[source]
paths = [
"src/adapter/etl-adapter-avro/src/Flow",
"src/adapter/etl-adapter-avro/tests/Flow",
"src/adapter/etl-adapter-chartjs/src/Flow",
"src/adapter/etl-adapter-chartjs/tests/Flow",
"src/adapter/etl-adapter-csv/src/Flow",
"src/adapter/etl-adapter-csv/tests/Flow",
"src/adapter/etl-adapter-doctrine/src/Flow",
"src/adapter/etl-adapter-doctrine/tests/Flow",
"src/adapter/etl-adapter-elasticsearch/src/Flow",
"src/adapter/etl-adapter-elasticsearch/tests/Flow",
"src/adapter/etl-adapter-excel/src/Flow",
"src/adapter/etl-adapter-excel/tests/Flow",
"src/adapter/etl-adapter-google-sheet/src/Flow",
"src/adapter/etl-adapter-google-sheet/tests/Flow",
"src/adapter/etl-adapter-http/src/Flow",
"src/adapter/etl-adapter-http/tests/Flow",
"src/adapter/etl-adapter-json/src/Flow",
"src/adapter/etl-adapter-json/tests/Flow",
"src/adapter/etl-adapter-logger/src/Flow",
"src/adapter/etl-adapter-logger/tests/Flow",
"src/adapter/etl-adapter-meilisearch/src/Flow",
"src/adapter/etl-adapter-meilisearch/tests/Flow",
"src/adapter/etl-adapter-parquet/src/Flow",
"src/adapter/etl-adapter-parquet/tests/Flow",
"src/adapter/etl-adapter-text/src/Flow",
"src/adapter/etl-adapter-text/tests/Flow",
"src/adapter/etl-adapter-xml/src/Flow",
"src/adapter/etl-adapter-xml/tests/Flow",
"src/bridge/filesystem/async-aws/src/Flow",
"src/bridge/filesystem/async-aws/tests/Flow",
"src/bridge/filesystem/azure/src/Flow",
"src/bridge/filesystem/azure/tests/Flow",
"src/bridge/monolog/http/src/Flow",
"src/bridge/monolog/http/tests/Flow",
"src/bridge/openapi/specification/src/Flow",
"src/bridge/openapi/specification/tests/Flow",
"src/bridge/symfony/http-foundation/src/Flow",
"src/bridge/symfony/http-foundation/tests/Flow",
"src/cli/src/Flow",
"src/cli/tests/Flow",
"src/core/etl/src/Flow",
"src/core/etl/tests/Flow",
"src/lib/array-dot/src/Flow",
"src/lib/array-dot/tests/Flow",
"src/lib/azure-sdk/src/Flow",
"src/lib/azure-sdk/tests/Flow",
"src/lib/doctrine-dbal-bulk/src/Flow",
"src/lib/doctrine-dbal-bulk/tests/Flow",
"src/lib/dremel/src/Flow",
"src/lib/dremel/tests/Flow",
"src/lib/filesystem/src/Flow",
"src/lib/filesystem/tests/Flow",
"src/lib/parquet-viewer/src/Flow",
"src/lib/parquet-viewer/tests/Flow",
"src/lib/parquet/src/Flow",
"src/lib/parquet/tests/Flow",
"src/lib/snappy/src/Flow",
"src/lib/snappy/tests/Flow",
"src/lib/types/src/Flow",
"src/lib/types/tests/Flow",
"src/tools/documentation/src/Flow",
"src/tools/documentation/tests/Flow"
]
includes = [
"vendor",
"tools/phpunit/vendor"
]
excludes = [
"src/lib/parquet/src/Flow/Parquet/ThriftModel"
]

[formatter]
print-width = 140
control-brace-style = "same_line"
closure-brace-style = "same_line"
function-brace-style = "same_line"
method-brace-style = "next_line"
classlike-brace-style = "next_line"
inline-empty-control-braces = true
inline-empty-closure-braces = true
inline-empty-function-braces = true
inline-empty-method-braces = true
inline-empty-classlike-braces = true
inline-empty-constructor-braces = true
inline-empty-anonymous-class-braces = true
expand-use-groups = false

[linter]
integrations = ["symfony"]

[linter.rules]
no-redundant-use = { enabled = true }
too-many-methods = { enabled = false }
excessive-parameter-list = { enabled = false }
kan-defect = { enabled = false }
cyclomatic-complexity = { enabled = false }
no-error-control-operator = { enabled = false }
too-many-enum-cases = { enabled = false }
too-many-properties = { enabled = false }
no-literal-password = { enabled = false }
literal-named-argument = { enabled = false }
halstead = { enabled = false }
no-boolean-flag-parameter = { enabled = false }
interface-name = { enabled = false }
class-name = { enabled = false }
trait-name = { enabled = false }
function-name = { enabled = false }
constant-name = { enabled = false }
no-else-clause = { enabled = false }
no-empty-catch-clause = { enabled = false }
explicit-octal = { enabled = false }
no-redundant-parentheses = { enabled = false }
no-boolean-literal-comparison = { enabled = false }
no-multi-assignments = { enabled = false }
no-goto = { enabled = false }
use-compound-assignment = { enabled = false }
no-ini-set = { enabled = false }
no-assign-in-condition = { enabled = false }
tagged-todo = { enabled = false }
no-redundant-file = { enabled = false }
excessive-nesting = { enabled = false }
prefer-first-class-callable = { enabled = false }
loop-does-not-iterate = { enabled = false }
no-empty-loop = { enabled = false }
no-debug-symbols = { enabled = true }
no-shorthand-ternary = { enabled = false }
parameter-type = { enabled = false }
return-type = { enabled = false }
no-redundant-method-override = { enabled = false }

[analyzer]
find-unused-definitions = true
find-unused-expressions = false
analyze-dead-code = false
check-throws = false
allow-possibly-undefined-array-keys = true
perform-heuristic-checks = true
2 changes: 2 additions & 0 deletions rector.src.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Rector\CodingStyle\Rector\FunctionLike\FunctionLikeToFirstClassCallableRector;
use Rector\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector;
use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
use Rector\Php74\Rector\Ternary\ParenthesizeNestedTernaryRector;

return RectorConfig::configure()
->withPaths([
Expand All @@ -26,6 +27,7 @@
StringClassNameToClassConstantRector::class,
__DIR__ . '/src/lib/parquet/src/Flow/Parquet/ThriftModel/*',
])
->withSkip([ParenthesizeNestedTernaryRector::class])
->withCache(__DIR__ . '/var/rector/src')
->withImportNames(importShortClasses: false, removeUnusedImports: true)
->withSets([
Expand Down
3 changes: 0 additions & 3 deletions rector.tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,5 @@
->withCache(__DIR__ . '/var/rector/tests')
->withSkipPath(__DIR__ . '/src/lib/parquet/src/Flow/Parquet/Thrift')
->withImportNames(
importNames: true,
importDocBlockNames: true,
importShortClasses: false,
removeUnusedImports: true
);
1 change: 1 addition & 0 deletions tools/mago/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
vendor
13 changes: 13 additions & 0 deletions tools/mago/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "flow-php/flow-tools",
"description": "Flow PHP ETL - Tools",
"minimum-stability": "dev",
"prefer-stable": true,
"require-dev": {
"php": "~8.2.0 || ~8.3.0 || ~8.4.0",
"carthage-software/mago": "dev-main"
},
"config": {
"allow-plugins": true
}
}
Loading
Loading