Skip to content

Neos 9 compatibility #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Neos 9 compatibility #18

wants to merge 16 commits into from

Conversation

robinroloff
Copy link

No description provided.

kdambekalns
kdambekalns reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work if the migration has been executed in the past…

But then you need to manually delete the table, to make it work (again) with the updated Doctrine dependencies… (because that's the reason, json_array having disappeared there).

robinroloff and others added 3 commits April 4, 2025 12:42
@robinroloff @kdambekalns
Update composer.json
58956db 
Co-authored-by: Karsten Dambekalns <[email protected]>
changed migration to drop the table before creating it for backwards …
e76ae80 
…compatibility

changed migration to ask for abstractmysqlplatform instead of mariadb
Merge remote-tracking branch 'origin/main'
fa53523
@robinroloff
Copy link
Author

@kdambekalns Updated it, check it out

kdambekalns
kdambekalns reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left more comments… 🙃

kdambekalns
kdambekalns requested changes Apr 7, 2025
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we cannot simply drop the table – the hashes are created manually with the provided CLI command,this isn't just a cache (my bad for not seeing thisn earlier).

So, this needs to be a migration altering the existing table…

@robinroloff
Copy link
Author

@kdambekalns i changed it now. I added a new migration that updates the column instead of recreating the table.

@robinroloff robinroloff requested a review from kdambekalns April 7, 2025 11:40
@robinroloff robinroloff requested a review from kdambekalns April 22, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns Awaiting requested review from kdambekalns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinroloff @kdambekalns