Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #34

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Performance improvements #34

merged 5 commits into from
Jun 4, 2024

Conversation

MSallermann
Copy link
Contributor

Improves performance by

  • getting rid of bounds check in topography::locate_point
  • caching sin and cos in lobe::rasterize_perimeter

Removed the out of bounds checks for locate_point, since they were quite
expensive and (most of the time) unnecessary.
New overloads for point_at_angle and rasterize_perimeter, which take
pre-computed sin and cos values.
This improves the performance of find_preliminary_budding_point
@MSallermann MSallermann requested a review from amritagos as a code owner June 4, 2024 15:05
@MSallermann MSallermann merged commit 3e8474b into main Jun 4, 2024
7 checks passed
@MSallermann MSallermann deleted the performance_improvements branch July 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant