add missing location arguments for JobReference struct #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker1007
previously approved these changes
Feb 9, 2025
joker1007
requested changes
Feb 9, 2025
lib/fluent/plugin/bigquery/writer.rb
Outdated
| @@ -167,7 +167,7 @@ def create_load_job(chunk_id, chunk_id_hex, project, dataset, table_id, upload_s | |||
| log.error "job.load API", project_id: project, dataset: dataset, table: table_id, code: e.status_code, message: e.message | |||
|
|
|||
| if job_id && e.status_code == 409 && e.message =~ /Job/ # duplicate load job | |||
| return JobReference.new(chunk_id, chunk_id_hex, project, dataset, table_id, job_id) | |||
| return JobReference.new(chunk_id, chunk_id_hex, project, dataset, table_id, job_id, res.job_reference.location) | |||
There was a problem hiding this comment.
Because the res variable is the return of insert_job, I cannot use the res variable in the case of failure of insert_job.
It is necessary to reacquire the location separately.
For example, you can use dataset get API.
There was a problem hiding this comment.
Thank you for your reviews!
I have modified it to use the data obtained during the table existence check as the location in case of duplication. bc6c534
https://googleapis.dev/ruby/google-api-client/latest/Google/Apis/BigqueryV2/Table.html
…plicate load jobs
joker1007
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the missing
locationargument is properly passed to the JobReference in the error handler that runs when a duplicate job entry is inserted.Please review the changes.