check connection status befor the put_copy_end method #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this bug-fix is due to an error after DB connection, if you use BUFFER in fluentd configuration file with this plugin.
You have this problem if the connection to DB is already established and after the connection interruption the plugin tries to use the put_copy_end method to send the end-of-data indication to the server, but if the connection doesn't exists or it's was interrupted, plugin can't send request and generates an error.
At this point the only possibility to restore the connection is to restart fluentd process so that the connection is re-established with the DB and the data is send again.
The if on code checks if you have a valid connection or not, if not it resets the connection immediately.
After many tests, it seems to work correctly with the option of Buffer.
Best regards