Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change#1449
Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change#1449douglasawh wants to merge 4 commits intofluent:masterfrom
Conversation
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate. The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users. Signed-off-by: Doug Whitfield <dwhitfield@perforce.com>
lockewritesdocs
left a comment
lockewritesdocs
left a comment
There was a problem hiding this comment.
Thanks for your contribution @douglasawh! I suggested some editorial changes to incorporate.
This language much better than my original PR. All I *had* done is take what was in there, reformat it slightly, and move it to the top. Co-authored-by: Adam Locke <adam.locke@chronosphere.io> Signed-off-by: Doug Whitfield <douglasawh@gmail.com>
|
Hi @douglasawh, Thanks |
lecaros
added
waiting-for-user
douglasawh
changed the title
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
eschabell
added
conflict
|
@douglasawh can you please fix the conflicts here so I can merge for you? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
esmerel
removed
conflict
|
The conflicts were due to formatting changes for style, I went ahead and fixed the conflicts in the interest of keeping things moving. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
The DCO failure is a hard block |
eschabell
added
dco
|
@douglasawh if you can look at the DCO failures, we've pushed through the original conflicts for you, would love to have this PR in a clean state to merge? |
eschabell
added
the
waiting-for-user
6 participants
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate.
The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users.