in_tail: Add descriptions for encoding parameters on in tail #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-encoding-parameter-on-in_tail
branch
from
d8ef3d9 to
331b498
Compare
7 tasks
|
@fluent/chronosphere-tech-writers could you please review this one? Thanks in advance! |
alexakreizinger
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
suggested some changes for style, but adding my approval based on those 😁 happy to take another look if you need to make changes to any of my changes, too. (also I want to make sure any changes stay in sync with #1471!)
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Also I added the reason why we need to support these parameters and how to use them. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-encoding-parameter-on-in_tail
branch
from
331b498 to
19afe22
Compare
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-encoding-parameter-on-in_tail
branch
from
e206b78 to
2b5890b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subsequent PR of #1471.
Also I added the reason why we need to support these parameters and how
to use them.