Dockerfile: optimize layers #10103
Open
Dockerfile: optimize layers #10103
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
marcofranssen
force-pushed
the
optimize-dockerfile
branch
from
ba4bd2f to
b718be6
Compare
marcofranssen
commented
Mar 19, 2025
| @@ -177,8 +177,7 @@ RUN find /dpkg/ -type d -empty -delete && \ | |||
| # We want latest at time of build | |||
| # hadolint ignore=DL3006 | |||
| FROM gcr.io/distroless/cc-debian12 AS production | |||
| ARG RELEASE_VERSION | |||
| ENV FLUENT_BIT_VERSION=${RELEASE_VERSION} | |||
| EXPOSE 2020 | |||
There was a problem hiding this comment.
Moved up, as this is not likely to change, meaning the layer doesn't have to be rebuild,pushed,pulled.
patrick-stephens
approved these changes
Mar 20, 2025
marcofranssen
force-pushed
the
optimize-dockerfile
branch
from
b718be6 to
ab34957
Compare
|
Rebased on top of master branch and fixed following small mistake. |
Squashed some layers to reduce the amount of layers in the image. Also rearranged some layers to reduce the amount of layers that have to be rebuild. If one layer changes all layers after have to be updated. By moving the ones least likely to change first this means less layers have to be rebuild, pushed and pulled on new releases. Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
optimize-dockerfile
branch
from
ab34957 to
f60ed47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.