Skip to content

Conversation

ThomasDevoogdt
Copy link
Contributor

@ThomasDevoogdt ThomasDevoogdt commented Jun 7, 2025

See https://autobuild.buildroot.org/results/ade/ade1783e6a8a9025a4fc12a8370d479662b84ec4/build-end.log.

In file included from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxh3.h:55,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl_hash.h:26,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl.h:33,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_config_map.h:27,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_output.h:36,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:22:
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxhash.h:3962:5: warning: #warning "XXH3 is highly inefficient without ARM or Thumb-2." [-Wcpp]
 3962 | #   warning "XXH3 is highly inefficient without ARM or Thumb-2."
      |     ^~~~~~~
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c: In function 'put_log_events':
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]
 1540 |             if (c->resp.data == NULL || c->resp.data_len == 0 || strcasestr(c->resp.data, AMZN_REQUEST_ID_HEADER) == NULL) {
      |                                                                  ^~~~~~~~~~
      |                                                                  strcasecmp

See https://autobuild.buildroot.org/results/ade/ade1783e6a8a9025a4fc12a8370d479662b84ec4/build-end.log.

In file included from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxh3.h:55,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl_hash.h:26,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl.h:33,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_config_map.h:27,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_output.h:36,
                 from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:22:
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxhash.h:3962:5: warning: #warning "XXH3 is highly inefficient without ARM or Thumb-2." [-Wcpp]
 3962 | #   warning "XXH3 is highly inefficient without ARM or Thumb-2."
      |     ^~~~~~~
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c: In function 'put_log_events':
/workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]
 1540 |             if (c->resp.data == NULL || c->resp.data_len == 0 || strcasestr(c->resp.data, AMZN_REQUEST_ID_HEADER) == NULL) {
      |                                                                  ^~~~~~~~~~
      |                                                                  strcasecmp

Signed-off-by: Thomas Devoogdt <[email protected]>
@ThomasDevoogdt
Copy link
Contributor Author

@cosmo0920

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, strcasestr should be enabled with _GNU_SOURCE. Good catch! 👍

@ThomasDevoogdt
Copy link
Contributor Author

@cosmo0920 It has been a while, can this be merged?

@edsiper edsiper merged commit a67e952 into fluent:master Jul 8, 2025
48 of 50 checks passed
@edsiper edsiper added this to the Fluent Bit v4.0.4 milestone Jul 8, 2025
@edsiper
Copy link
Member

edsiper commented Jul 8, 2025

thank you

arnout pushed a commit to buildroot/buildroot that referenced this pull request Sep 13, 2025
News:
 - https://fluentbit.io/announcements/v4.0.4/
 - https://fluentbit.io/announcements/v4.0.5/
 - https://fluentbit.io/announcements/v4.0.6/
 - https://fluentbit.io/announcements/v4.0.7/
 - https://fluentbit.io/announcements/v4.0.8/
 - https://fluentbit.io/announcements/v4.0.9/

Fixes:
 - https://autobuild.buildroot.org/results/770/770e9106a0c92f02e0f699505e69b35ac0e6cd41/build-end.log

   /home/buildroot/instance-0/output-1/build/fluent-bit-4.0.3/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]

   Fix commit: fluent/fluent-bit#10452

Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
arnout pushed a commit to buildroot/buildroot that referenced this pull request Sep 19, 2025
News:
 - https://fluentbit.io/announcements/v4.0.4/
 - https://fluentbit.io/announcements/v4.0.5/
 - https://fluentbit.io/announcements/v4.0.6/
 - https://fluentbit.io/announcements/v4.0.7/
 - https://fluentbit.io/announcements/v4.0.8/
 - https://fluentbit.io/announcements/v4.0.9/

Fixes:
 - https://autobuild.buildroot.org/results/770/770e9106a0c92f02e0f699505e69b35ac0e6cd41/build-end.log

   /home/buildroot/instance-0/output-1/build/fluent-bit-4.0.3/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]

   Fix commit: fluent/fluent-bit#10452

Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
(cherry picked from commit 39afca7)
Signed-off-by: Thomas Perale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants