-
Notifications
You must be signed in to change notification settings - Fork 1.8k
out_cloudwatch_logs: fix strcasestr _GNU_SOURCE #10452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://autobuild.buildroot.org/results/ade/ade1783e6a8a9025a4fc12a8370d479662b84ec4/build-end.log. In file included from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxh3.h:55, from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl_hash.h:26, from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/include/cfl/cfl.h:33, from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_config_map.h:27, from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/include/fluent-bit/flb_output.h:36, from /workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:22: /workdir/instance-0/output-1/build/fluent-bit-4.0.2/lib/cfl/lib/xxhash/xxhash.h:3962:5: warning: #warning "XXH3 is highly inefficient without ARM or Thumb-2." [-Wcpp] 3962 | # warning "XXH3 is highly inefficient without ARM or Thumb-2." | ^~~~~~~ /workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c: In function 'put_log_events': /workdir/instance-0/output-1/build/fluent-bit-4.0.2/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration] 1540 | if (c->resp.data == NULL || c->resp.data_len == 0 || strcasestr(c->resp.data, AMZN_REQUEST_ID_HEADER) == NULL) { | ^~~~~~~~~~ | strcasecmp Signed-off-by: Thomas Devoogdt <[email protected]>
cosmo0920
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, strcasestr should be enabled with _GNU_SOURCE. Good catch! 👍
@cosmo0920 It has been a while, can this be merged? |
thank you |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 13, 2025
News: - https://fluentbit.io/announcements/v4.0.4/ - https://fluentbit.io/announcements/v4.0.5/ - https://fluentbit.io/announcements/v4.0.6/ - https://fluentbit.io/announcements/v4.0.7/ - https://fluentbit.io/announcements/v4.0.8/ - https://fluentbit.io/announcements/v4.0.9/ Fixes: - https://autobuild.buildroot.org/results/770/770e9106a0c92f02e0f699505e69b35ac0e6cd41/build-end.log /home/buildroot/instance-0/output-1/build/fluent-bit-4.0.3/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration] Fix commit: fluent/fluent-bit#10452 Signed-off-by: Thomas Devoogdt <[email protected]> Signed-off-by: Julien Olivain <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 19, 2025
News: - https://fluentbit.io/announcements/v4.0.4/ - https://fluentbit.io/announcements/v4.0.5/ - https://fluentbit.io/announcements/v4.0.6/ - https://fluentbit.io/announcements/v4.0.7/ - https://fluentbit.io/announcements/v4.0.8/ - https://fluentbit.io/announcements/v4.0.9/ Fixes: - https://autobuild.buildroot.org/results/770/770e9106a0c92f02e0f699505e69b35ac0e6cd41/build-end.log /home/buildroot/instance-0/output-1/build/fluent-bit-4.0.3/plugins/out_cloudwatch_logs/cloudwatch_api.c:1540:66: error: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration] Fix commit: fluent/fluent-bit#10452 Signed-off-by: Thomas Devoogdt <[email protected]> Signed-off-by: Julien Olivain <[email protected]> (cherry picked from commit 39afca7) Signed-off-by: Thomas Perale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://autobuild.buildroot.org/results/ade/ade1783e6a8a9025a4fc12a8370d479662b84ec4/build-end.log.