Skip to content

Conversation

RomanPryamonosov
Copy link

Added missing headers for compilation on Centos 10.
Reports with errors on the undefined htons function in two files

[2025-06-12T16:28:19.598Z] /tmp/fluent-bit/lib/nghttp2-1.65.0/lib/nghttp2_helper.c:33:16: error: implicit declaration of function ‘htons’ [-Wimplicit-function-declaration]
[2025-06-12T16:28:19.598Z]    33 |   uint16_t x = htons(n);

[N/A]

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [NA] Example configuration file for the change
  • [NA] Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@patrick-stephens
Copy link
Contributor

I think this is a change to the vendored dependency so needs to be submitted there first then we take the update once released.

Also, I don't think we have a Centos 10 target yet so we should add that too otherwise we can't prove it builds.

@cosmo0920
Copy link
Contributor

I think this is a change to the vendored dependency so needs to be submitted there first then we take the update once released.

Also, I don't think we have a Centos 10 target yet so we should add that too otherwise we can't prove it builds.

Yes, this will also be impacted for archlinux which is one of the cutting-adge distributions.

@cosmo0920
Copy link
Contributor

This issue is resolved by #10517.
This is because the implicit functions were caused by config.h collisions between onigmo and nghttp2.
In that PR, we resolved such collisions.

@edsiper
Copy link
Member

edsiper commented Jul 7, 2025

resolved in #10517

@edsiper edsiper closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants