Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthrough
ChangesCondition value conversion
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Numeric condition thresholds now use the expected representation, with no unresolved material risk identified in the changed path. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c98ec2e to
b57bb99
Compare
b57bb99 to
8a9245c
Compare
When a condition rule uses GT/LT/GTE/LTE with an integer variant (CFL_VARIANT_INT or CFL_VARIANT_UINT), the value pointer was typed as int64_t*/uint64_t* but rule_create read it as double* via *(double*)value, producing a garbage comparison threshold. Converts INT and UINT variants to double at the call site before passing the address to flb_condition_add_rule, so the callee always receives a proper double*. Signed-off-by: Florian <florian.bezannier@hotmail.fr>
8a9245c to
48a8899
Compare
When a condition rule uses GT/LT/GTE/LTE with an integer variant (CFL_VARIANT_INT or CFL_VARIANT_UINT), the value pointer was typed as int64_t*/uint64_t* but rule_create read it as double* via (double)value, producing a garbage comparison threshold.
Fix: convert INT and UINT variants to double at the call site before passing the address to flb_condition_add_rule, so the callee always receives a proper double*.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit