-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor_labels: add support for record accessor in values #9841
Conversation
Signed-off-by: Eduardo Silva <[email protected]>
ebc1d3a
to
daad13e
Compare
…anges Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
} | ||
|
||
TEST_LIST = { | ||
#ifdef FLB_HAVE_METRICS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just my curiosity but do we need to use this if def for test cases? This is because when disabling FLB_HAVE_METRICS, the defined test cases are not effective under this condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm maybe we don't need it... I don't think metrics are optional anymore
Label processors allow to manipulate the labels from metrics, this PR extends the actions
insert
,update
andupsert
to support a record accessor pattern that helps to use the$TAG
variable that can be populated dinamically, e.g:Fluent Bit output:
This PR also adds a new unit test for the processor.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.