log: increase precision in log's timestamp to nanoseconds #9985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lecaros
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
edsiper
requested changes
Feb 21, 2025
lecaros
force-pushed
the
lecaros-add-nanosecond-to-log
branch
from
35af7f3 to
4d0149b
Compare
|
ping @edsiper |
|
I feel v4.0 is a reasonable time to make it the default, the risk should be minor. @edsiper How do you feel about it? |
lecaros
force-pushed
the
lecaros-add-nanosecond-to-log
branch
from
4d0149b to
2216177
Compare
|
@leonardo-albertovich I recommend triaging that potential issue in a separate PR (so both can make the cut for 4.0.3) |
|
I think that'd be quite cumbersome because it means this PR which depends on that would have to wait and get rebased. Is there a specific reason to do so? |
|
moving to next milestone due to code conflict and resolution |
lecaros
force-pushed
the
lecaros-add-nanosecond-to-log
branch
from
501200e to
c34de5a
Compare
Signed-off-by: lecaros <[email protected]>
lecaros
force-pushed
the
lecaros-add-nanosecond-to-log
branch
from
8b1d3db to
2198c3b
Compare
|
code conflict resolved. @edsiper |
|
ping @edsiper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nanoseconds precision to the logs Fluent Bit writes.
It's possible in some cases that the underlying implementation of the time functions won't provide nanoseconds precision. In those cases, the precision will be to microseconds, which is still better than to the second. (see here)
Addresses #9983
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.