-
Notifications
You must be signed in to change notification settings - Fork 309
helm(v4): Breaks fluentd-crds out into separate top-level chart #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm(v4): Breaks fluentd-crds out into separate top-level chart #1790
Conversation
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
| repository: "file://charts/fluent-bit-crds" | ||
| version: 3.5.0 | ||
| condition: fluentbit.crdsEnable | ||
| - name: fluentd-crds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added fluentd-crds as a dependency to the main chart. Instead of file:// references, we're pointing to the published chart and pinning to a specific version.
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
marcofranssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Part of fixing #1765.