fix: fix the e2e test script for fluentd #1791
Conversation
cw-Guo
force-pushed
the
fix/fluentd-e2e
branch
from
e768108 to
d647fa0
Compare
cw-Guo
force-pushed
the
fix/fluentd-e2e
branch
from
a26fb8e to
87b92da
Compare
| @@ -1 +1 @@ | |||
| v3.5.0 | |||
| latest No newline at end of file | |||
There was a problem hiding this comment.
Don't think this change belongs to this PR
| latest | |
| v3.5.0 | |
There was a problem hiding this comment.
it will block the test to run successfully if we don't fix it. see here
There was a problem hiding this comment.
Changing this will break stuff like releases, we rather fix it in the script by doing a sed replacement or something like that.
There was a problem hiding this comment.
No, the release #1741 should be actually be merged into a separate release branch and keep the master's version to latest. There was a mistake that we didn't create a release branch for v3.5.0
Please check the file history and you will know.
apis/fluentd/v1alpha1/tests/expected/fluentd-namespaced-cfg-filter-selector.cfg
Outdated
Show resolved
Hide resolved
apis/fluentd/v1alpha1/tests/expected/fluentd-namespaced-cfg-filter-output-selector.cfg
Outdated
Show resolved
Hide resolved
marcofranssen
force-pushed
the
fix/fluentd-e2e
branch
3 times, most recently
from
bc9fdb8 to
4c46ec8
Compare
marcofranssen
left a comment
marcofranssen
left a comment
There was a problem hiding this comment.
Couple suggestions to simplify
marcofranssen
force-pushed
the
fix/fluentd-e2e
branch
from
6e95e26 to
ab8acf5
Compare
cw-Guo
force-pushed
the
fix/fluentd-e2e
branch
2 times, most recently
from
1069a58 to
0c99b62
Compare
Signed-off-by: Chengwei Guo <[email protected]>
Signed-off-by: Chengwei Guo <[email protected]>
Signed-off-by: Chengwei Guo <[email protected]>
Signed-off-by: Chengwei Guo <[email protected]>
Signed-off-by: chengweiguo <[email protected]>
Signed-off-by: chengweiguo <[email protected]>
Signed-off-by: chengweiguo <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: chengweiguo <[email protected]>
cw-Guo
force-pushed
the
fix/fluentd-e2e
branch
from
0c99b62 to
6f2fc45
Compare
|
Hi @marcofranssen , please fix the DCO issue for the last commit and also the e2e-test itself, right now it still fails due to the changes in last commit. |
2 participants
What this PR does / why we need it:
As titled, after this fix, we can run
make e2esuccessfully.