helm(v4): Breaks fluent-bit-crds out into separate top-level chart #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
joshuabaird
changed the title
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the fluent-bit-crds from an embedded sub-chart within fluent-operator to a separate, independently versioned top-level chart. This mirrors the approach previously taken for fluentd-crds and enables better CRD lifecycle management with automatic upgrades via helm upgrade.
Key Changes:
- Created new top-level
fluent-bit-crdschart (v0.1.0) with proper metadata and documentation - Removed the old embedded sub-chart from
charts/fluent-operator/charts/fluent-bit-crds - Added support for
additionalAnnotationsin all Fluent Bit CRD templates to enable thehelm.sh/resource-policy: keepannotation pattern
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/fluent-bit-crds/Chart.yaml | New top-level chart metadata with proper versioning, maintainers, and keywords |
| charts/fluent-bit-crds/values.yaml | Adds additionalAnnotations configuration option for CRD lifecycle management |
| charts/fluent-bit-crds/README.md | Auto-generated documentation for the new chart |
| charts/fluent-bit-crds/README.md.gotmpl | Template for generating chart documentation |
| charts/fluent-bit-crds/.helmignore | Standard Helm ignore patterns for the new chart |
| charts/fluent-bit-crds/templates/*.yaml | All 13 Fluent Bit CRD templates now include additionalAnnotations support with consistent formatting |
| charts/fluent-operator/Chart.yaml | Updates dependency to reference the new external chart repository with proper condition |
| charts/fluent-operator/charts/fluent-bit-crds/Chart.yaml | Removed embedded sub-chart (also fixes typo "fluenbt-bit" that existed in old file) |
| charts/fluent-operator/charts/fluent-bit-crds/values.yaml | Removed embedded sub-chart values file |
| charts/fluent-operator/MIGRATION-v4.md | Comprehensive documentation updates explaining the CRD lifecycle changes for both Fluent Bit and Fluentd |
| hack/mutate-crds.sh | Adds fluent-bit-crds templates to the CRD mutation script |
| Makefile | Updates manifests target to generate CRDs to new location and adds helm-docs for fluent-bit-crds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Josh Baird <[email protected]>
joshuabaird
commented
Nov 20, 2025
Signed-off-by: Josh Baird <[email protected]>
joshuabaird
force-pushed
the
chore/fluent-bit-chart
branch
from
365b62f to
e66f7e4
Compare
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
cw-Guo
pushed a commit
to cw-Guo/fluent-operator
that referenced
this pull request
Nov 22, 2025
…luent#1795) * Add new fluent-bit-crds chart. Signed-off-by: Josh Baird <[email protected]> * Modify depdendncy. Signed-off-by: Josh Baird <[email protected]> * Remove legacy chart. Signed-off-by: Josh Baird <[email protected]> * Reset. Signed-off-by: Josh Baird <[email protected]> * Update migration doc. Signed-off-by: Josh Baird <[email protected]> * Use file references for dev. Signed-off-by: Josh Baird <[email protected]> * Use repo URLs for deps. Signed-off-by: Josh Baird <[email protected]> * Add cwGuo email. Signed-off-by: Josh Baird <[email protected]> * Apply suggestion from @marcofranssen Signed-off-by: Marco Franssen <[email protected]> * Apply suggestion from @marcofranssen Signed-off-by: Marco Franssen <[email protected]> * Apply suggestion from @marcofranssen Signed-off-by: Marco Franssen <[email protected]> * Apply suggestion from @marcofranssen Signed-off-by: Marco Franssen <[email protected]> --------- Signed-off-by: Josh Baird <[email protected]> Signed-off-by: Marco Franssen <[email protected]> Co-authored-by: Marco Franssen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing #1765.