Skip to content

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Mar 7, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
This patch will fix following error:

NoMethodError: undefined method `seek' for nil:NilClass
/home/runner/work/fluentd/fluentd/lib/fluent/log/console_adapter.rb:61:in `call'
/opt/hostedtoolcache/Ruby/3.2.7/x64/lib/ruby/gems/3.2.0/gems/console-1.30.0/lib/console/output/wrapper.rb:35:in `call'
/opt/hostedtoolcache/Ruby/3.2.7/x64/lib/ruby/gems/3.2.0/gems/console-1.30.0/lib/console/output/failure.rb:38:in `call'
/opt/hostedtoolcache/Ruby/3.2.7/x64/lib/ruby/gems/3.2.0/gems/console-1.30.0/lib/console/filter.rb:48:in `block (3 levels) in []'
/home/runner/work/fluentd/fluentd/test/log/test_console_adapter.rb:58:in `test_args'

Ref. https://github.com/fluent/fluentd/actions/runs/13714056838

The variable name was changed at
socketry/console@1529fef#diff-757206aeb67c0bd1c0d1813dfbff0a140a68920505520e8163b3a274fbab05ceR30

Since now Fluentd assumes Ruby 3.2 or later, this discards the related code to support Ruby before v3.1.

Docs Changes:
Not needed.

Release Note:
The same as the title.

@Watson1978 Watson1978 requested a review from daipom March 7, 2025 06:44
@daipom daipom added this to the v1.19.0 milestone Mar 7, 2025
@daipom daipom changed the title console_adapter: fix variable name which changed at console gem v1.30 console_adapter: support console gem v1.30 Mar 7, 2025
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

@daipom daipom merged commit 8df1086 into fluent:master Mar 7, 2025
9 of 10 checks passed
@Watson1978 Watson1978 deleted the console branch March 7, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants