Skip to content

http_server: stop fallback to WEBrick #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Apr 10, 2025

Which issue(s) this PR fixes:

What this PR does / why we need it:
Make http_server plugin helper stop the fallback to WEBrick.

WEBrick is no longer recommended for production use.

We don't need this feature because it was for supporting Ruby < 2.3. (#2447)

Docs Changes:
https://docs.fluentd.org/plugin-helper-overview/api-plugin-helper-http_server
=> fluent/fluentd-docs-gitbook#575

Release Note:
The same as the title.

WEBrick is no longer recommended for production use.

We don't need this feature because it was for supporting Ruby <
2.3. (fluent#2447)

Signed-off-by: Daijiro Fukuda <[email protected]>
daipom added a commit to daipom/fluentd-docs-gitbook that referenced this pull request Apr 10, 2025
@daipom daipom added this to the v1.19.0 milestone Apr 10, 2025
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@daipom daipom merged commit 83c19d1 into fluent:master Apr 10, 2025
10 checks passed
@daipom daipom deleted the http_server-stop-fallback-to-webrick branch April 10, 2025 07:50
@daipom
Copy link
Contributor Author

daipom commented Apr 10, 2025

Thanks for your review!

daipom added a commit to fluent/fluentd-docs-gitbook that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace WEBrick because it is no longer recommended for production use
3 participants