-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support fuse pods to launch in eager mode #4571
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: EvanCley <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @EvanCley. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EvanCley Thank you for the contribution. Please help fix the ut issue:
|
Signed-off-by: EvanCley <[email protected]>
OK, the ut fix have done. |
pkg/ctrl/affinity.go
Outdated
// if fuse launch mode is eager, set worker node affinity by fuse node selector | ||
if e.runtimeInfo.GetFuseLaunchMode() == datav1alpha1.EagerMode { | ||
for key, val := range e.runtimeInfo.GetFuseNodeSelector() { | ||
workersToUpdate.Spec.Template.Spec.Affinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current implementation creates separate PreferredSchedulingTerm for each label, should we combine into single term?
term := corev1.NodeSelectorTerm{
MatchExpressions: []corev1.NodeSelectorRequirement{
{Key: "user-label1", Operator: In, Values: ["val1"]},
{Key: "user-label2", Operator: In, Values: ["val2"]}
}}
workers.Spec.Template.Spec.Affinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution =
[]corev1.PreferredSchedulingTerm{{Weight: 100, Preference: term}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice suggestion, I will revise it
Signed-off-by: EvanCley <[email protected]>
|
/test fluid-e2e |
Ⅰ. Describe what this PR does
support fuse pods to launch in both eager and lazy mode, default to lazy mode
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
all included in the second commit
Ⅳ. Describe how to verify it
create dataset and any type of runtime with fuse.spec.launchMode, and then alluxio fuse pods will running on the nodes with nodeSelector labels
Ⅴ. Special notes for reviews