Skip to content

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Mar 17, 2025

Shows a circular progress indicator around the spool icon.

Screenshot (progress values are random for demo purposes)

image

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Mar 17, 2025
@pedrolamas pedrolamas added this to the 1.33.1 milestone Mar 17, 2025
@pedrolamas pedrolamas requested a review from matmen March 17, 2025 23:32
@pedrolamas
Copy link
Member Author

@matmen layout is never my thing, so if you have any thoughts on how better to show this, I'm all ears... 😁

Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to test this yet (though the code LGTM), but layout wise it looks fine to me :) At first I was unsure if the blue part was showing how much filament has already been used or how much is left on the spool, but I guess it makes sense for it to show how much is left

@moggieuk
Copy link
Contributor

moggieuk commented Mar 20, 2025

I'm not suggesting you change the base icon but users of the Happy Hare panel like the readability of a simple %. Could you layer a rectangle with % in contrasting color?
Screenshot 2025-03-20 at 9 22 28 PM

The use of progress meter is cute but doesn't immediately jump out at me with purpose. I do like having a simple indication of available filament though.
Caveat: I'm not a designer :-)

@pedrolamas
Copy link
Member Author

@moggieuk I did notice that on Happy Hare and do like it!

I ran a couple of experiments on this layout and didn't reach something I actually liked, so for now I will merge this as-is and revisit at a later time for improvements!

@pedrolamas pedrolamas merged commit 4edc84c into fluidd-core:develop Mar 20, 2025
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/spoolman-spool-progress branch March 20, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants