Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to stream without cache #10

Merged
merged 4 commits into from
May 30, 2018
Merged

Add method to stream without cache #10

merged 4 commits into from
May 30, 2018

Conversation

arj03
Copy link
Contributor

@arj03 arj03 commented May 27, 2018

When doing large reads the overhead in a cache in the getMeta function can be quite substantial (15%). Also if I know that I'm going to do a lot of reads that I will not need again, there is no reason to blow the cache for everyone else.

I think it would be a good idea to use it here so that indexing is faster.

@dominictarr
Copy link
Collaborator

I think I'd rather have an option to disable cache on stream rather than a second method. It might also be good to use that option when, say, rebuilding views? I suggest cache option that defaults to false, so {cache: false} streams everything without cache.

@arj03
Copy link
Contributor Author

arj03 commented May 28, 2018

Yes, it would be really useful for rebuilding views. I'll look into the cache option.

@arj03
Copy link
Contributor Author

arj03 commented May 28, 2018

Thanks for pointing me in the right direction dominic. Adding it to pull-cursor is a more modular design.

@arj03 arj03 closed this May 28, 2018
@arj03 arj03 reopened this May 28, 2018
@arj03
Copy link
Contributor Author

arj03 commented May 28, 2018

This should be good now I think. Depends on dominictarr/pull-cursor#2.

@arj03 arj03 merged commit 1ef90fa into master May 30, 2018
@arj03
Copy link
Contributor Author

arj03 commented May 30, 2018

@dominictarr I merged this and bumped versions. The same with bench-flumelog 1.2.0 but I don't have permissions on npm to publish them. I did publish pull-cursor 3.0.0 though.

@dominictarr
Copy link
Collaborator

dominictarr commented May 31, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants