Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #13 by wrapping codecs in
Promise.resolve
orPromise.all
for batch operations, and adds an async test which is just theflumelog.js
test withsetTimeout
. This shouldn't have any effect on synchronous codecs.I don't think we're currently handling codec errors, so I've left
reject()
unused, but if there's an elegant way to handle promise rejections I'd be happy to implement it.