Respect buffer option in codec and return buffer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, I had actually found this problem and fixed it locally but forgot to publish. merged! |
|
Hmm. I went back to this again. Merged and released as 3.3.2. Btw test/restore is failing but is also failing on main. Any idea what is up with that @dominictarr? |
|
Oh, you already released 3.3.2 to npm but didn't update github? |
|
Ha! You also fixed the tests on the npm released version. I took the changes and pushed everything so that things should now be in sync, except the log on your local machine ;-) |
|
oops! pulling did a weird merge so I've just switched my local master to be your master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should respect buffer option in codec for what we want to return. This allows us to use something that works faster on buffer directly ;-)