-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple deletion #16
Conversation
christianbundy
commented
Feb 12, 2019
- Add .gitignore and update deps
- Add simple del method to overwrite data with null bytes
- Use non-deprecated buffer methods
- Remove unused variables
Backlink: depends on flumedb/aligned-block-file#5 |
I read the commit, how does this affect performance? I see that stream now filters all elements, so I'm wondering what kind of overhead this might or might not have? |
Thanks for the review! I took a look at the performance and noticed that master
1351d03 (slow)
32a1392
|
Excellent @christianbundy! The commit looks good, I'm not sure if blanking is the best option, havn't thought deeply enough about that, but I trust you on that. I really appreciate you driving deletion forward! |
Thanks @arj03! If you think of any other techniques I'd be happy to hear them, this shouldn't require a migration or anything so we can always change the implementation if we come up with something clever. I've got a call with Dominic in a bit, I'm going to check in with him before merging just in case. 👍 |
Oops, this slipped my mind on the call -- any changes you'd like to see @dominictarr? |