Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use 48 or 53 bits to encode file length #6

Merged
merged 8 commits into from
Jul 29, 2017

Conversation

regular
Copy link
Contributor

@regular regular commented Jul 7, 2017

As discussed in #2
This also re-enables the restore/tests (now for all bitnesses)
Not sure about the "provide a number of bits as offsetCodec" shortcut and using numbers as properties in what frame/offset-codecs exports. What do you think?

@regular
Copy link
Contributor Author

regular commented Jul 28, 2017

@dominictarr ping :)

@dominictarr
Copy link
Collaborator

oh sorry, I thought this was merged. I'm getting sleepy now, I'll merge this tomorrow!

@regular
Copy link
Contributor Author

regular commented Jul 28, 2017 via email

@dominictarr dominictarr merged commit d076bf7 into flumedb:master Jul 29, 2017
@dominictarr
Copy link
Collaborator

thanks! merged into 3.2.0

@dominictarr
Copy link
Collaborator

newer is a good policy. I would like to do via git-ssb but the thing that is missing is a decent inbox/queue of open issues that I need to handle, so it's easy for things to slip past. For me, this is the number 1 thing that git-ssb needs most (cc @cel)

Also, for things that I hope to have a broader appeal outside of ssb internals (flume, pull-streams) I will use github too, because I hope to get users who arn't on ssb yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants