-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to use 48 or 53 bits to encode file length #6
Conversation
…ilesizeCodec object
@dominictarr ping :) |
oh sorry, I thought this was merged. I'm getting sleepy now, I'll merge this tomorrow! |
Oh, don't worry, there's no rush.
Btw: do you prefer PRs on ssb or github these days? (if both repos exist).
I tend to check which one is newer to decide where to put the PR.
Have a good night!
…On Fri, Jul 28, 2017 at 12:44 PM, Dominic Tarr ***@***.***> wrote:
oh sorry, I thought this was merged. I'm getting sleepy now, I'll merge
this tomorrow!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHgUo5124-8DhMjROOZcedJaGZQwZpHks5sSbuQgaJpZM4OQyxB>
.
|
thanks! merged into 3.2.0 |
newer is a good policy. I would like to do via git-ssb but the thing that is missing is a decent inbox/queue of open issues that I need to handle, so it's easy for things to slip past. For me, this is the number 1 thing that git-ssb needs most (cc @cel) Also, for things that I hope to have a broader appeal outside of ssb internals (flume, pull-streams) I will use github too, because I hope to get users who arn't on ssb yet. |
As discussed in #2
This also re-enables the restore/tests (now for all bitnesses)
Not sure about the "provide a number of bits as
offsetCodec
" shortcut and using numbers as properties in whatframe/offset-codecs
exports. What do you think?