Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_app_purchases codelab update #2295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RobertOdrowaz
Copy link

This PR is for a matching docs update. There are only minor changes in the code:

  1. googlePlayProjectName -> googleCloudProjectId const rename to make it more appropriate. It is used for Pub/Sub to which Google Play publishes purchase-related events but it's on Google Cloud so we need the ID of the GCP project.
  2. Steps 09 and 10 were misaligned relative to the instructions and should be steps 10 and 11 instead.
  3. Minor update to backend readme. The constants.dart already exists, there was a typo in one of the placeholder values, and constants.dart uses single quotes.

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants