Repository navigation
Update animations flutter version - #2894
Open
domesticmouse wants to merge 16 commits into
Open
domesticmouse wants to merge 16 commits into
domesticmouse wants to merge 16 commits into
Conversation
Codelabs in this repository are generated from declarative `codelab_rebuild.yaml` blueprints rather than maintained by editing generated `step_XX/` directories by hand. Add a workspace skill under `.agents/skills/codelab-rebuild/` so AI agents know how to invoke `tooling/codelab_rebuild`, follow the scratch-directory and step-snapshot workflow, debug broken patches using `stop: true`, and validate rebuilt codelab steps against the repository's CI checks. Split the complete `Blueprint` and `BlueprintStep` YAML schema and validation rules into `references/blueprint-schema.md` for progressive disclosure, keeping `SKILL.md` focused on the core workflow.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the 'codelab_rebuild' tool and updates the 'animations' codelab steps (from 'step_01' to 'step_05_d') to target Dart SDK '^3.14.0', upgrade dependencies, and update Android, Linux, Windows, and Web build configurations. It also migrates iOS and macOS runner tests from 'XCTest' to 'Swift Testing'. The review feedback correctly notes that the migrated Swift test functions are missing the required '@test' attribute, which prevents them from being recognized or executed by the test runner.
The `base64 -b 76` flag is specific to BSD `base64` on macOS and fails on Linux where GNU `base64` uses `-w 76`. Update the `codelab-rebuild` skill instructions to provide a cross-platform `fold -w 76` alternative and explicitly note the macOS and Linux flag differences.
…tter_version # Conflicts: # animations/step_01/pubspec.lock # animations/step_02_a/pubspec.lock # animations/step_02_b/pubspec.lock # animations/step_02_c/pubspec.lock # animations/step_02_d/pubspec.lock # animations/step_02_e/pubspec.lock # animations/step_03_a/pubspec.lock # animations/step_03_b/pubspec.lock # animations/step_03_c/pubspec.lock # animations/step_03_d/pubspec.lock # animations/step_04_a/pubspec.lock # animations/step_04_b/pubspec.lock # animations/step_04_c/pubspec.lock # animations/step_04_d/pubspec.lock # animations/step_05_a/pubspec.lock # animations/step_05_b/pubspec.lock # animations/step_05_c/pubspec.lock # animations/step_05_d/pubspec.lock
… skill Replace bash/zsh process substitution (`<(...)`) with a standard pipe to `fold -w 76` so the cross-platform `base64-contents` encoding command works across POSIX `sh` as well as bash and zsh environments.
… update_animations_flutter_version
… update_animations_flutter_version
… update_animations_flutter_version
Contributor
Author
|
PTAL @parlough , this is the last PR of the release =) |
… update_animations_flutter_version # Conflicts: # .agents/skills/codelab-rebuild/SKILL.md
…m/domesticmouse/codelabs into update_animations_flutter_version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.