Repository navigation
Update deeplink cookbook - #2898
Merged
domesticmouse merged 17 commits intoNov 13, 2026
Merged
Conversation
Codelabs in this repository are generated from declarative `codelab_rebuild.yaml` blueprints rather than maintained by editing generated `step_XX/` directories by hand. Add a workspace skill under `.agents/skills/codelab-rebuild/` so AI agents know how to invoke `tooling/codelab_rebuild`, follow the scratch-directory and step-snapshot workflow, debug broken patches using `stop: true`, and validate rebuilt codelab steps against the repository's CI checks. Split the complete `Blueprint` and `BlueprintStep` YAML schema and validation rules into `references/blueprint-schema.md` for progressive disclosure, keeping `SKILL.md` focused on the core workflow.
The `base64 -b 76` flag is specific to BSD `base64` on macOS and fails on Linux where GNU `base64` uses `-w 76`. Update the `codelab-rebuild` skill instructions to provide a cross-platform `fold -w 76` alternative and explicitly note the macOS and Linux flag differences.
… skill Replace bash/zsh process substitution (`<(...)`) with a standard pipe to `fold -w 76` so the cross-platform `base64-contents` encoding command works across POSIX `sh` as well as bash and zsh environments.
…dependencies - Update `deeplink_cookbook/codelab_rebuild.yaml` to remove the redundant `material_ui` addition (now included by default in `flutter create`) and add a `flutter pub upgrade --major-versions` step so dependencies like `cupertino_icons` remain at their latest major versions across rebuilds. - Regenerate platform runners and upgrade dependencies (`sdk: ^3.14.0`, `go_router: ^18.1.4`, `material_ui: ^1.11.0`, `cupertino_icons: ^2.0.0`).
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the codelab_rebuild tool and its blueprint schema, alongside updates to the deeplink_cookbook project, including dependency upgrades, SDK constraint bumps, and migration of iOS and macOS tests to Swift Testing. Feedback highlights a typo in pubspec.yaml that incorrectly downgrades the material_ui version constraint, missing @Test annotations in the migrated Swift tests which will prevent them from running, and an inaccuracy in the documentation regarding default imports in standard Flutter templates.
Add `flutter pub upgrade --major-versions` to `codelab_rebuild.yaml` while retaining `material_ui` in `flutter pub add` so that recreating the project upgrades all dependency constraints (including `cupertino_icons` and `material_ui`) rather than reverting to the default template bounds. Re-run `codelab_rebuild` to update `deeplink_cookbook` for the current Flutter and Dart SDK.
Although `flutter create` now includes `material_ui` in `pubspec.yaml` by default, it pins an older minimum version constraint (`^1.1.0`) that `flutter pub upgrade --major-versions` does not update when no new major version exists. Removing `material_ui` from `flutter: pub add` steps therefore unintentionally downgrades the minimum constraint in `pubspec.yaml` even when a newer version is resolved in `pubspec.lock`. Update the skill guidance to keep `material_ui` in `flutter: pub add` (or use `flutter: pub upgrade --tighten`) so rebuilt codelabs retain up-to-date `material_ui` version constraints.
… update_deeplink_cookbook # Conflicts: # .agents/skills/codelab-rebuild/SKILL.md
… update_deeplink_cookbook
… update_deeplink_cookbook
parlough
approved these changes
Nov 12, 2026
… update_deeplink_cookbook # Conflicts: # .agents/skills/codelab-rebuild/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.