Skip to content

Update deeplink cookbook - #2898

Merged
domesticmouse merged 17 commits into
flutter:mainfrom
domesticmouse:update_deeplink_cookbook
Nov 13, 2026
Merged

domesticmouse merged 17 commits into
flutter:mainfrom
domesticmouse:update_deeplink_cookbook

Conversation

@domesticmouse

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Codelabs in this repository are generated from declarative `codelab_rebuild.yaml` blueprints rather than maintained by editing generated `step_XX/` directories by hand. Add a workspace skill under `.agents/skills/codelab-rebuild/` so AI agents know how to invoke `tooling/codelab_rebuild`, follow the scratch-directory and step-snapshot workflow, debug broken patches using `stop: true`, and validate rebuilt codelab steps against the repository's CI checks.

Split the complete `Blueprint` and `BlueprintStep` YAML schema and validation rules into `references/blueprint-schema.md` for progressive disclosure, keeping `SKILL.md` focused on the core workflow.
The `base64 -b 76` flag is specific to BSD `base64` on macOS and fails on Linux where GNU `base64` uses `-w 76`. Update the `codelab-rebuild` skill instructions to provide a cross-platform `fold -w 76` alternative and explicitly note the macOS and Linux flag differences.
… skill

Replace bash/zsh process substitution (`<(...)`) with a standard pipe to `fold -w 76` so the cross-platform `base64-contents` encoding command works across POSIX `sh` as well as bash and zsh environments.
…dependencies

- Update `deeplink_cookbook/codelab_rebuild.yaml` to remove the redundant `material_ui` addition (now included by default in `flutter create`) and add a `flutter pub upgrade --major-versions` step so dependencies like `cupertino_icons` remain at their latest major versions across rebuilds.
- Regenerate platform runners and upgrade dependencies (`sdk: ^3.14.0`, `go_router: ^18.1.4`, `material_ui: ^1.11.0`, `cupertino_icons: ^2.0.0`).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the codelab_rebuild tool and its blueprint schema, alongside updates to the deeplink_cookbook project, including dependency upgrades, SDK constraint bumps, and migration of iOS and macOS tests to Swift Testing. Feedback highlights a typo in pubspec.yaml that incorrectly downgrades the material_ui version constraint, missing @Test annotations in the migrated Swift tests which will prevent them from running, and an inaccuracy in the documentation regarding default imports in standard Flutter templates.

Comment thread deeplink_cookbook/pubspec.yaml Resolved
Comment thread .agents/skills/codelab-rebuild/SKILL.md Resolved
Add `flutter pub upgrade --major-versions` to `codelab_rebuild.yaml` while retaining `material_ui` in `flutter pub add` so that recreating the project upgrades all dependency constraints (including `cupertino_icons` and `material_ui`) rather than reverting to the default template bounds. Re-run `codelab_rebuild` to update `deeplink_cookbook` for the current Flutter and Dart SDK.
Although `flutter create` now includes `material_ui` in `pubspec.yaml` by default, it pins an older minimum version constraint (`^1.1.0`) that `flutter pub upgrade --major-versions` does not update when no new major version exists. Removing `material_ui` from `flutter: pub add` steps therefore unintentionally downgrades the minimum constraint in `pubspec.yaml` even when a newer version is resolved in `pubspec.lock`.

Update the skill guidance to keep `material_ui` in `flutter: pub add` (or use `flutter: pub upgrade --tighten`) so rebuilt codelabs retain up-to-date `material_ui` version constraints.
… update_deeplink_cookbook

# Conflicts:
#	.agents/skills/codelab-rebuild/SKILL.md
… update_deeplink_cookbook

# Conflicts:
#	.agents/skills/codelab-rebuild/SKILL.md
@domesticmouse
domesticmouse merged commit 8f87334 into flutter:main Nov 13, 2026
13 checks passed
@domesticmouse
domesticmouse deleted the update_deeplink_cookbook branch November 13, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants