Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Add back the device name with the running tab #7948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Feb 21, 2025

Recovers the ability of #6774.

myDisplayName no longer exists in the com.intellij.execution.ui.RunContentDescriptor, it has been replaced by a MutableReactiveProperty myDisplayNameView since 2024 builds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 self-assigned this Feb 21, 2025
@AlexV525 AlexV525 force-pushed the fix/launch-descriptor-with-device-name branch 3 times, most recently from 5f69c50 to 6d21c82 Compare February 21, 2025 03:48
@AlexV525 AlexV525 force-pushed the fix/launch-descriptor-with-device-name branch from 6d21c82 to 4096930 Compare February 21, 2025 03:51
@AlexV525 AlexV525 marked this pull request as ready for review February 21, 2025 04:01
@AlexV525 AlexV525 changed the title ♻️ Refactored from myDisplayName to myDisplayNameView to add back the device name with the running tab ♻️ Add back the device name with the running tab Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant