Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support Release 85 - IntelliJ 2025.1 #7963

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mossmana
Copy link

@mossmana mossmana commented Mar 7, 2025

Changes to support Release 85 - IntelliJ 2025.1

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@mossmana
Copy link
Author

@jwren I'll address the merge conflict that resulted because of the the changes you landed for #7964. However, I'm probably going to need your eyes on this because I'm not entirely clear what else needs to change to get the DART_BOT passing.

@mossmana mossmana requested a review from jwren March 10, 2025 22:00
@jwren
Copy link
Member

jwren commented Mar 10, 2025

You need to rebase to master to pick up the change in .github/workflows/presubmit.yaml, then you won't get any failures from 2023.3.

Since you are adding 2025.1 into the product matrix you need to also add that version into the presubmit.yaml file to make sure it passes before it lands.

@mossmana
Copy link
Author

@jwren The presubmit is failing on this PR because of a missing dependency on 'com.google.tools.ij.aiplugin'

https://github.com/flutter/flutter-intellij/actions/runs/13792585218/job/38576076264?pr=7963#step:3:506

Can you help me figure out the correct dependencies for IntelliJ?

@jwren
Copy link
Member

jwren commented Mar 11, 2025

That plugin has not yet been uploaded for 2025.1 see https://plugins.jetbrains.com/plugin/24198-gemini-code-assist. All you need to do is to have the addition of this plugin be conditionally added in the Kotlin Gradle file, for this version of IJ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants