Skip to content

[DeviceSelectorAction] 🐛 Replace the action list without concurrent modification #8550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2025
Merged

[DeviceSelectorAction] 🐛 Replace the action list without concurrent modification #8550

merged 4 commits into from
Sep 26, 2025

Conversation

AlexV525
Copy link
Member

Fixes #8544

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@AlexV525 AlexV525 added this to the M88 milestone Sep 25, 2025
@AlexV525 AlexV525 self-assigned this Sep 25, 2025
@AlexV525 AlexV525 added the 🤖 AI-assisted For PRs with significant code generated by AI label Sep 25, 2025
@AlexV525 AlexV525 requested review from pq and helin24 September 25, 2025 02:26
helin24
helin24 requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I follow what's happening here, but I'm hoping we can start a new practice of adding some debug-level logs for these situations where concurrency can make things confusing. Could you (or AI) add some here that will show what's happening in updateActions? and then show what happens in a successful case? I'll add a few examples.

@AlexV525
Copy link
Member Author

Logs were added

helin24
helin24 requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Just fix the class name.

src/io/flutter/actions/DeviceSelectorAction.java Outdated
import java.util.List;

public class DeviceSelectorAction extends AnAction implements CustomComponentAction, DumbAware {
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterDoctorAction.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeviceSelectorAction

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good catch!

@AlexV525 AlexV525 requested a review from helin24 September 26, 2025 02:51
@AlexV525

This comment was marked as outdated.

Sign in to view
helin24
helin24 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helin24 helin24 merged commit 36ef16e into flutter:main Sep 26, 2025
7 checks passed
@AlexV525 AlexV525 deleted the fix/8544 branch September 27, 2025 01:51
@AlexV525 AlexV525 mentioned this pull request Sep 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helin24 helin24 helin24 approved these changes

@pq pq Awaiting requested review from pq

Assignees

@AlexV525 AlexV525

Labels
🤖 AI-assisted For PRs with significant code generated by AI
Projects
None yet
Milestone
M88
Development

Successfully merging this pull request may close these issues.

ConcurrentModificationException when opening projects
2 participants
@AlexV525 @helin24