Skip to content

Delete example verdure and platforms that we do not test for.#894

Open
polina-c wants to merge 3 commits intoflutter:mainfrom
polina-c:del-platforms
Open

Delete example verdure and platforms that we do not test for.#894
polina-c wants to merge 3 commits intoflutter:mainfrom
polina-c:del-platforms

Conversation

@polina-c
Copy link
Copy Markdown
Collaborator

No description provided.

@polina-c polina-c requested a review from jacobsimionato April 30, 2026 02:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's platform support policy to focus on macos and web, removing unsupported platform directories across various examples and updating the contributing guidelines. Feedback indicates that the verdure example was only partially deleted, leaving behind source and server code that should be removed if no longer supported. Additionally, the reviewer noted inconsistencies in the platform directory deletions across different examples and recommended a more thorough cleanup to ensure all unsupported platforms are removed uniformly.

Comment thread examples/README.md
Comment thread CONTRIBUTING.md
No longer needed after platform code (Android/iOS/Linux/Windows) was
removed; the gradle cache lookup was failing because no gradle files
remain in the repo.
@polina-c polina-c changed the title Delete platforms that we do not test for. Delete example verdure and platforms that we do not test for. Apr 30, 2026
@jacobsimionato
Copy link
Copy Markdown
Collaborator

jacobsimionato commented May 1, 2026

Hey can you chat to Alan about Verdure? I think I agree with you we can just delete it now that it's served its purpose, but he might have good reasons to keep it. Some other options would be:

  • Test it first in case it works, in which case we can move it to a separate repo and pin the SDK versions that it uses
  • Get it working again

@jacobsimionato
Copy link
Copy Markdown
Collaborator

Re the other apps:
Can we delete windows and linux but keep iOS and Android and try to support them? They are the major platforms that people associate with Flutter and iOS was working last time I checked, so I think we should continue to support them.

I think macos/web/ios/android is a good set to aim for (macos purely for our own dev purposes). WDYT?

@polina-c
Copy link
Copy Markdown
Collaborator Author

polina-c commented May 1, 2026

Let's have discussion on the team.

It is cost to support many platforms.

Not sure we want to pay this cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants