[local_auth] Adopt structured errors and remove useErrorDialogs - platform implementations #10147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
stuartmorgan-g
requested review from
mboetger,
okorohelijah and
vashworth
as code owners
|
This is just #9981 with the changes outside of the platform implementation packages reverted, for separate landing. |
stuartmorgan-g
added
the
federated: partial_changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the error handling across Android, Darwin, and Windows platforms to use a new structured LocalAuthException, and removes the deprecated useErrorDialogs option. The changes are comprehensive and well-aligned with the goal of modernizing the error reporting. I've identified a critical compilation issue in the Dart implementation for Darwin and provided a suggested fix. Otherwise, the platform-specific implementations and their corresponding tests are well-executed.
julien4215
added a commit
to aeecleclair/Titan
that referenced
this pull request
Oct 8, 2025
To handle the exceptions in a better way we should use the exceptions of the package local_auth when this gets released: flutter/packages#10147.
@vashworth @mboetger can check this and transfer over your LGTM to here? #9981 |
vashworth
approved these changes
Oct 15, 2025
mboetger
approved these changes
Oct 15, 2025
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2025
…logs - platform implementations (flutter/packages#10147)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2025
flutter/packages@d062181...835dccb 2025-10-16 [email protected] [local_auth] Adopt structured errors and remove useErrorDialogs - platform implementations (flutter/packages#10147) 2025-10-16 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.mockito.kotlin:mockito-kotlin from 6.0.0 to 6.1.0 in /packages/interactive_media_ads/android (flutter/packages#10221) 2025-10-15 [email protected] Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) (flutter/packages#10229) 2025-10-15 [email protected] [go_router] feat: access GoRouter.of from redirect methods (flutter/packages#9706) 2025-10-14 [email protected] [Many] Migrate non examples (and pigeon test) to java 17 (flutter/packages#10201) 2025-10-13 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.36.0 to 3.37.0 in /packages/interactive_media_ads/android (flutter/packages#10113) 2025-10-13 [email protected] [pigeon] Fixes support for Kotlin/Java classes that override equals and hashCode for ProxyApis (flutter/packages#10039) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2025
flutter/packages@d062181...835dccb 2025-10-16 [email protected] [local_auth] Adopt structured errors and remove useErrorDialogs - platform implementations (flutter/packages#10147) 2025-10-16 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.mockito.kotlin:mockito-kotlin from 6.0.0 to 6.1.0 in /packages/interactive_media_ads/android (flutter/packages#10221) 2025-10-15 [email protected] Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) (flutter/packages#10229) 2025-10-15 [email protected] [go_router] feat: access GoRouter.of from redirect methods (flutter/packages#9706) 2025-10-14 [email protected] [Many] Migrate non examples (and pigeon test) to java 17 (flutter/packages#10201) 2025-10-13 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.36.0 to 3.37.0 in /packages/interactive_media_ads/android (flutter/packages#10113) 2025-10-13 [email protected] [pigeon] Fixes support for Kotlin/Java classes that override equals and hashCode for ProxyApis (flutter/packages#10039) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementation portion of #9981
LocalAuthExceptionclass for structured errors.AuthenticationOptions.useErrorDialogsPart of:
local_authplugin flutter#113687useErrorDialogsflutter#175125Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3