Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

The web_helpers.dart file was a helper for an inlined version of cross_file that was originally part of this package. When the inline version was replaced with an import of cross_file, when that was split into its own package, this file wasn't cleaned up, so it was dead code.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

The `web_helpers.dart` file was a helper for an inlined version of
cross_file that was originally part of this package. When the inline
version was replaced with an import of `cross_file`, when that was split
into its own package, this file wasn't cleaned up, so it was dead code.
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 6, 2025
@stuartmorgan-g
Copy link
Collaborator Author

CHANGELOG/version override: since this is removing non-exported code that nothing was importing internally, it's a no-op.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the file packages/file_selector/file_selector_platform_interface/lib/src/web_helpers/web_helpers.dart. This file contained web-specific helper functions (createAnchorElement, addElementToContainerAndClick, ensureInitialized) that are no longer used. This change correctly removes dead code, resulting in a cleaner codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: file_selector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant