[go_router_builder] Support extension types #9458

koji-1009 · 2025-06-20T00:11:42Z

Extended type_helpers.dart to support Dart extension types.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

chunhtai · 2025-06-23T17:19:58Z

packages/go_router_builder/lib/src/type_helpers.dart

+      return '$stateValue as $castType';
+    }
+
+    final String parseTypeName =


Should we guard against no primitive type? since this is following by a hardcode tryParse, may as well only allow certain numeric types?

I think you are right in pointing this out. I restricted the type and handled it correctly. 61901a3

chunhtai

code lgtm, just need an example

chunhtai · 2025-07-02T18:35:59Z

packages/go_router_builder/README.md

 ## Type conversions

-The code generator can convert simple types like `int` and `enum` to/from the
+The code generator can convert simple types like `int`, `enum`, and `extension type` to/from the


We should add a new example in example/ folder

hannah-hyj

LGTM, thank you for writing the examples!

hannah-hyj · 2025-07-07T19:27:25Z

packages/go_router_builder/example/lib/all_extension_typs.dart

@@ -0,0 +1,408 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.


typo in the file name: typs-> types

Sorry! I fixed. c57f3d0

hannah-hyj · 2025-07-07T19:28:44Z

packages/go_router_builder/lib/src/type_helpers.dart

 }

+/// A type helper for extension types.
+/// Suppoted extension types are:


nit: Suppoted-> Supported

Sorry, I fixed! c57f3d0

justinmc · 2025-07-21T18:11:27Z

@koji-1009 You had a failure that I just reran. If it still fails, can you take a look? Maybe you just need to push a merge commit / rebase.

koji-1009 · 2025-07-21T21:37:48Z

@justinmc
Thanks for mention. The error message is following.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8708712639707483713/+/u/Run_package_tests/CHANGELOG_and_version_validation/stdout?format=raw

--packages-for-branch: running on branch "HEAD".
Running for all packages that have diffs relative to "d9d3191ea6cf5b2a040b3368171112c1da736483"

Changed packages: go_router_builder
[0:00] Running for packages/go_router_builder...
  3.0.1 -> 3.1.0
  When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.


The following packages had errors:
  packages/go_router_builder:
    CHANGELOG.md failed validation.
See above for full details.

This “NEXT” section was described at #9453. Because of this, go_router_builder is in a difficult situation for minor version upgrades until the build issue is resolved.

I believe that the problem of build could have been solved at #9649.

koji-1009 · 2025-08-13T23:08:08Z

Added examples file. Merged the main branch, and all tests passed 👍

chunhtai

LGTM

* main: (56 commits) [go_router_builder] Support extension types (flutter#9458) Roll Flutter from e2a347b14a18 to 34c2a3b158b2 (41 revisions) (flutter#9803) [go_router_builder] Migrate to Element2 API and update dependencies (flutter#9649) [in_app_purchase_storekit] Add support for quantity in consumable product purchases (#171570) (flutter#9698) [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter#9756) Roll Flutter from 1590543f6794 to e2a347b14a18 (1 revision) (flutter#9784) [camera_avfoundation] Implementation swift migration - part 11 (flutter#9690) [camera_avfoundation] Fix crash when streaming while recording (flutter#9691) Roll Flutter from 38217906e95c to 1590543f6794 (14 revisions) (flutter#9780) Roll Flutter from 92a6bfbfd6ef to 38217906e95c (17 revisions) (flutter#9778) [video_player] Improve KVO handling on iOS (flutter#9718) [dependabot]: Bump the test-dependencies group across 15 directories with 7 updates (flutter#9736) Roll Flutter from 9de63a03428f to 92a6bfbfd6ef (11 revisions) (flutter#9769) [google_maps_flutter_platform_interface] Add Advanced markers support (flutter#9737) [camera_android_camerax] Re-land "Force new Surface for each SurfaceRequest" (flutter#9760) [google_maps_flutter] Add ability to perform Google Maps SDK warmup (flutter#9674) Roll Flutter from 59fc766c6fdf to 9de63a03428f (6 revisions) (flutter#9764) [webview_flutter_wkwebview] Extended Web View API on iOS to add flexibility when working with local HTML content (flutter#8787) [local_auth] Differentiate iOS authentication errors (flutter#9705) manual roll to 59fc766c6fdfd03d0983fc95ce8b76793a300dd5 (flutter#9758) ... # Conflicts: # packages/go_router_builder/lib/src/type_helpers.dart # packages/go_router_builder/pubspec.yaml

…es#9458)

flutter/packages@6cb9113...09533b7 2025-08-14 [email protected] Roll Flutter from 34c2a3b to f4334d2 (18 revisions) (flutter/packages#9807) 2025-08-14 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/packages#9805) 2025-08-13 [email protected] [go_router_builder] Support extension types (flutter/packages#9458) 2025-08-13 [email protected] Roll Flutter from e2a347b to 34c2a3b (41 revisions) (flutter/packages#9803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#173789) flutter/packages@6cb9113...09533b7 2025-08-14 [email protected] Roll Flutter from 34c2a3b to f4334d2 (18 revisions) (flutter/packages#9807) 2025-08-14 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/packages#9805) 2025-08-13 [email protected] [go_router_builder] Support extension types (flutter/packages#9458) 2025-08-13 [email protected] Roll Flutter from e2a347b to 34c2a3b (41 revisions) (flutter/packages#9803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

koji-1009 added 2 commits June 20, 2025 09:09

feat: Support extension type

688ec24

chore: 3.0.2

bf334dc

github-actions bot added the p: go_router_builder label Jun 20, 2025

koji-1009 marked this pull request as ready for review June 20, 2025 04:07

koji-1009 requested a review from chunhtai as a code owner June 20, 2025 04:07

koji-1009 added 2 commits June 22, 2025 06:46

test: Remove nullable path case

8cf27d2

refactor: Fix encode case

af33a0b

chunhtai reviewed Jun 23, 2025

View reviewed changes

koji-1009 added 3 commits June 24, 2025 20:43

feat: Clarify which extension types are supported

61901a3

test: Update test cases

53e30bb

Merge branch 'main' into feat/extension_type

1a84b3a

koji-1009 requested a review from chunhtai June 26, 2025 13:09

koji-1009 added 2 commits July 1, 2025 18:52

chore: Fix version

9b9afeb

chore: fix

4a4d892

chunhtai reviewed Jul 2, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj July 2, 2025 18:36

chore: Add example

bcc5d26

hannah-hyj approved these changes Jul 7, 2025

View reviewed changes

fix: Fix typo

c57f3d0

koji-1009 requested a review from chunhtai July 10, 2025 01:39

koji-1009 added 5 commits August 14, 2025 07:13

Merge branch 'main' into feat/extension_type

57cf662

feat: Element2 API

5910235

chore: 3.2.0

ffdb723

refactor: dart format

9fc1ec2

refactor: dart format (test_input)

b8758e0

chunhtai approved these changes Aug 13, 2025

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025

auto-submit bot merged commit eab16dd into flutter:main Aug 13, 2025
80 checks passed

koji-1009 deleted the feat/extension_type branch August 13, 2025 23:40

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2025

eab16dd40 [go_router_builder] Support extension types (flutter/packag…

ccc70ff

…es#9458)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Packages from 6cb9113d5fa4 to eab16dd40d33 (2 revisions) flutter/flutter#173774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2025

eab16dd40 [go_router_builder] Support extension types (flutter/packag…

9348b0e

…es#9458)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Packages from 6cb9113d5fa4 to 84f113e07f33 (3 revisions) flutter/flutter#173778

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2025

eab16dd40 [go_router_builder] Support extension types (flutter/packag…

50ac62a

…es#9458)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Packages from 6cb9113d5fa4 to 09533b7d5d66 (4 revisions) flutter/flutter#173789

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router_builder] Support extension types #9458

[go_router_builder] Support extension types #9458

Uh oh!

koji-1009 commented Jun 20, 2025 •

edited

Loading

Uh oh!

chunhtai Jun 23, 2025

Uh oh!

koji-1009 Jun 25, 2025

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Jul 2, 2025

Uh oh!

hannah-hyj left a comment

Uh oh!

hannah-hyj Jul 7, 2025

Uh oh!

koji-1009 Jul 8, 2025

Uh oh!

hannah-hyj Jul 7, 2025

Uh oh!

koji-1009 Jul 8, 2025

Uh oh!

justinmc commented Jul 21, 2025

Uh oh!

koji-1009 commented Jul 21, 2025

Uh oh!

koji-1009 commented Aug 13, 2025

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,408 @@
		// Copyright 2013 The Flutter Authors. All rights reserved.

[go_router_builder] Support extension types #9458

[go_router_builder] Support extension types #9458

Uh oh!

Conversation

koji-1009 commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

chunhtai Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

koji-1009 Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

koji-1009 Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

koji-1009 Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc commented Jul 21, 2025

Uh oh!

koji-1009 commented Jul 21, 2025

Uh oh!

koji-1009 commented Aug 13, 2025

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

koji-1009 commented Jun 20, 2025 •

edited

Loading