Skip to content

[camera_android_camerax] Re-land "Force new Surface for each SurfaceRequest" #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jun 26, 2025

Important

flutter/flutter#169899 must be rolled into packages AND be in Flutter stable for this to land. I will try to cherry-pick this change into 3.32 stable once the 3.35 beta is cut. See flutter/flutter#171234 for a discussion on this choice.

Re-lands #9360.

Since timing for Surface requests cannot be guaranteed, request a new Surface from SurfaceProducer.getSurface each time a Surface is requested for rendering the camera preview to.

Fixes flutter/flutter#155294.
Fixes flutter/flutter#169506.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: camera platform-android waiting for stable update Can't be landed until functionality reaches the stable channel
Projects
None yet
1 participant