[camera_android_camerax] Fix the rotation of captured videos and streamed images

[camsim99]

wip :) todo:

• check if this fixes landscape oriented devices (if not fix -- this will also impact saved images)
• check if this fixes streamed images

Fixes flutter/flutter#163859.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of
Gemini Code Assist for GitHub.
Comments from the gemini-code-assist bot should not be taken as authoritative
feedback from the Flutter team. If you find its comments useful you can
update your code accordingly, but if you are unsure or disagree with the
feedback, please feel free to wait for a Flutter team member's review for
guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request refactors the orientation handling for video capture and image streaming by removing the stateful shouldSetDefaultRotation flag. The new logic is simpler and more robust, setting the target rotation on use cases whenever the orientation is not locked. This should fix the reported rotation issues. I've identified a couple of areas where performance could be improved by caching the last set rotation value to avoid redundant platform channel calls. These are not critical but would make the implementation more efficient.

[gemini-code-assist]

Consider extracting deviceOrientationManager.getDefaultDisplayRotation() to a local variable before calling proxy.newImageCapture. This avoids calling the platform multiple times, which could be inefficient.

final int defaultDisplayRotation = await deviceOrientationManager.getDefaultDisplayRotation();

[gemini-code-assist]

Instead of calling deviceOrientationManager.getDefaultDisplayRotation() directly within setTargetRotation, consider storing the value in a variable and reusing it. This avoids redundant calls to the platform, improving efficiency.

final rotation = await deviceOrientationManager.getDefaultDisplayRotation();
await videoCapture!.setTargetRotation(
  rotation,
);

[gemini-code-assist]

Instead of calling deviceOrientationManager.getDefaultDisplayRotation() directly within setTargetRotation, consider storing the value in a variable and reusing it. This avoids redundant calls to the platform, improving efficiency.

final rotation = await deviceOrientationManager.getDefaultDisplayRotation();
      await imageAnalysis!.setTargetRotation(
        rotation,
      );