-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update Accessibility docs #12513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Accessibility docs #12513
Conversation
Visit the preview URL for this PR (updated for commit 69b87bd): https://flutter-docs-prod--pr12513-refresh-a11y-2dmrp4ce.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the broken link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannah-hyj, this is a FABULOUS update to the accessibility docs! I have some minor edits, to make the text more consistent and so forth (and I previously fixed a broken link), but this is SUPER appreciated!
Fixed two more broken links
OK, I should have anticipated this. All sorts of internal links are breaking because of the new structure of the accessibility docs. I'm done for the day, but I can tackle this tomorrow. For one thing, we should set up redirects in the firebase.json file, so folks that link INTO our docs will end up at least roughly in the right place. |
|
||
* For web: | ||
1. Open Chrome DevTools (or similar tools in other browsers) | ||
2. Inspect the HTML tree containing the ARIA attributes generated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
html tree under semantics host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean update the wording here to "html tree under semantics host"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<br/> | ||
|
||
Check out the following [video demo][] to see Victor Tsaran, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit weird to call out a person's name like this, we should makes thing a bit anonymous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, @chunhtai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks!
When there is text in your app that should be voiced | ||
with a specific voice, inform the screen reader | ||
which voice to use by calling [`TextSpan.locale`][]. | ||
Note that `MaterialApp.locale` and `Localizations.override` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will affect the talkback locale in the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing for Semantics(localeForSubtree)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to "MaterialApp.locale
and Localizations.override
will affect screen reader voices starting from flutter 3.38 release." is it correct?
Understanding these tools helps in creating | ||
apps that are usable by people with diverse physical abilities. | ||
|
||
<table class="table table-striped"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use html instead of markdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I don't feel strongly enough about it to hold up this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
markdown table has no border and i think html table looks better
description: Information on Flutter's accessibility testing. | ||
--- | ||
|
||
## Inspecting accessibility support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere in this page should also mention checking against the public standard like WCAG and VPAT or EAA, ideally links to a self assessment template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thanks!
|
||
Both Android and iOS contain system settings to configure the desired font | ||
sizes used by apps. Flutter text widgets respect this OS setting when | ||
determining font sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a quick guide on how to adjust them in each devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
|
||
[W3C recommends]: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html | ||
|
||
## Tap target size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also mention the rest of https://api.flutter.dev/flutter/dart-ui/AccessibilityFeatures-class.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think I fixed the broken anchor and (I hope) the build will pass now.
@hannah-hyj, I will let you address @chunhtai's comments. But I think we are getting close!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it is well written! I don't have other comment besides these.
|
||
* For web: | ||
1. Open Chrome DevTools (or similar tools in other browsers) | ||
2. Inspect the HTML tree containing the ARIA attributes generated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</div> | ||
|
||
|
||
## Sufficient contrast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also mention we have guideline test
[W3C recommends]: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html | ||
|
||
## Tap target size | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here mention we have guideline, or link to the accessibility-testing.md
This PR did
added standards and regulation
added pictures and touch target size.
added mobility.
added nothing.
added how to opt-in using button or code
Presubmit checklist
of 80 characters or fewer.