Skip to content

Conversation

Copy link

Copilot AI commented Nov 26, 2025

  • Understand the issue: PaletteHuePicker's hue slider changes colors based on current saturation/value
  • Review similar pickers (PaletteSaturationPicker, PaletteValuePicker) for correct implementation pattern
  • Fix the hueColors getter to use hardcoded ARGB colors instead of dynamic colors based on current HSV
  • Fix const placement to match codebase style
  • Run code review - passed
  • Run security check - passed
  • Update version to 1.5.2 and CHANGELOG
Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug report] PaletteHuePicker changes Hue color while updating Palette color</issue_title>
<issue_description>### Version

1.5.0

Platforms

Web

Device Model

Google Chrome

flutter info

-

How to reproduce?

When you are using PaletteHuePicker and you change Palette color to darker or lighter - hue also changes. It can become black or white. I don't think it should work like that...
You can check this how it actually suppose to work
I have downloaded an example of a package and it works like this in it
Screenshot 2024-02-06 at 13 14 23
Screenshot 2024-02-06 at 13 14 30

Logs

No response

Example code (optional)

PaletteHuePicker(
          color: color,
          onChanged: onChanged,
        )

Contact

[email protected]</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix PaletteHuePicker hue change issue on palette update Fix PaletteHuePicker hue slider inheriting saturation/value from palette selection Nov 26, 2025
Copilot AI requested a review from nohli November 26, 2025 12:39
Copilot finished work on behalf of nohli November 26, 2025 12:39
@nohli nohli requested review from Copilot and removed request for nohli November 29, 2025 18:56
Copilot finished reviewing on behalf of nohli November 29, 2025 18:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the hue slider in PaletteHuePicker was incorrectly inheriting saturation and value from the current color selection, causing it to appear dark or desaturated when dark/desaturated colors were selected in the palette.

Key Changes:

  • Replaced dynamic hueColors getter with static hardcoded RGB values representing the full hue spectrum at maximum saturation and value
  • Ensures the hue slider always displays the complete color spectrum (Red → Yellow → Green → Cyan → Blue → Magenta → Red)
  • Aligns implementation with existing patterns in PaletteSaturationPicker and PaletteValuePicker

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nohli nohli marked this pull request as ready for review November 29, 2025 22:58
@nohli nohli requested review from AlexV525 and nohli as code owners November 29, 2025 22:58
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nohli
Copy link
Collaborator

nohli commented Nov 30, 2025

@copilot update version and changelog

Copy link
Author

Copilot AI commented Nov 30, 2025

@copilot update version and changelog

Updated version to 1.5.2 and added changelog entry in commit 27e1d5f.

Copilot AI requested a review from nohli November 30, 2025 13:36
Copilot finished work on behalf of nohli November 30, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug report] PaletteHuePicker changes Hue color while updating Palette color

3 participants