-
-
Notifications
You must be signed in to change notification settings - Fork 38
Fix PaletteHuePicker hue slider inheriting saturation/value from palette selection #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…aturation/value Co-authored-by: nohli <[email protected]>
Co-authored-by: nohli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the hue slider in PaletteHuePicker was incorrectly inheriting saturation and value from the current color selection, causing it to appear dark or desaturated when dark/desaturated colors were selected in the palette.
Key Changes:
- Replaced dynamic
hueColorsgetter with static hardcoded RGB values representing the full hue spectrum at maximum saturation and value - Ensures the hue slider always displays the complete color spectrum (Red → Yellow → Green → Cyan → Blue → Magenta → Red)
- Aligns implementation with existing patterns in
PaletteSaturationPickerandPaletteValuePicker
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexV525
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@copilot update version and changelog |
Co-authored-by: nohli <[email protected]>
hueColorsgetter to use hardcoded ARGB colors instead of dynamic colors based on current HSVOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.