Skip to content

imp: add log-level TOML config key#229

Merged
mergify[bot] merged 3 commits intoflux-framework:masterfrom
garlick:log_level
Apr 26, 2026
Merged

imp: add log-level TOML config key#229
mergify[bot] merged 3 commits intoflux-framework:masterfrom
garlick:log_level

Conversation

@garlick
Copy link
Copy Markdown
Member

@garlick garlick commented Apr 26, 2026

Problem: There is no way to enable IMP debug log output from the installed IMP executable.

Add a top-level log-level config key that accepts "warning", "info", or "debug". When set, it overrides the default (info) level.

garlick and others added 3 commits April 26, 2026 10:00
Problem: There is no way to enable IMP debug log output from
the installed IMP executable.

Add a top-level log-level config key that accepts "warning", "info",
or "debug". When set, it overrides the default (info) level.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Problem: The new log-level key has no documentation.

Add log-level to the top-level keys section of the IMP config man page.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Problem: The new log-level config key has no test coverage.

Add tests to t1000-imp-basic.t for accepted log levels (info, debug,
warning) and for an unknown level that should produce a warning.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.78%. Comparing base (84ef6ac) to head (485fe2d).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/imp/imp.c 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   84.90%   84.78%   -0.13%     
==========================================
  Files          38       38              
  Lines        5195     5154      -41     
==========================================
- Hits         4411     4370      -41     
  Misses        784      784              
Files with missing lines Coverage Δ
src/imp/imp.c 86.95% <94.11%> (+0.68%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garlick
Copy link
Copy Markdown
Member Author

garlick commented Apr 26, 2026

Thanks, I"ll set MWP.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 26, 2026

Merge Queue Status

  • Entered queue2026-04-26 18:27 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-04-26 18:27 UTC · at 485fe2d746c577535e649d427ed23add75443760 · merge

This pull request spent 10 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>0
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -title~=^\[*[Ww][Ii][Pp]
  • approved-reviews-by=@flux-framework/core
  • base=master
  • label!="work-in-progress"
  • label="merge-when-passing"
  • any of [🛡 GitHub branch protection]:
    • check-success = validate commits
    • check-neutral = validate commits
    • check-skipped = validate commits
  • any of [🛡 GitHub branch protection]:
    • check-success = spelling
    • check-neutral = spelling
    • check-skipped = spelling
  • any of [🛡 GitHub branch protection]:
    • check-success = coverage
    • check-neutral = coverage
    • check-skipped = coverage
  • any of [🛡 GitHub branch protection]:
    • check-success = bookworm
    • check-neutral = bookworm
    • check-skipped = bookworm
  • any of [🛡 GitHub branch protection]:
    • check-success = bookworm - 32 bit
    • check-neutral = bookworm - 32 bit
    • check-skipped = bookworm - 32 bit
  • any of [🛡 GitHub branch protection]:
    • check-success = bookworm - clang-15,chain-lint
    • check-neutral = bookworm - clang-15,chain-lint
    • check-skipped = bookworm - clang-15,chain-lint
  • any of [🛡 GitHub branch protection]:
    • check-success = bookworm - gcc-12,distcheck
    • check-neutral = bookworm - gcc-12,distcheck
    • check-skipped = bookworm - gcc-12,distcheck
  • any of [🛡 GitHub branch protection]:
    • check-success = el8
    • check-neutral = el8
    • check-skipped = el8
  • any of [🛡 GitHub branch protection]:
    • check-success = focal
    • check-neutral = focal
    • check-skipped = focal

@mergify mergify Bot merged commit d7f0566 into flux-framework:master Apr 26, 2026
24 of 26 checks passed
@mergify mergify Bot removed the queued label Apr 26, 2026
@garlick garlick deleted the log_level branch April 26, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants