Test reconcile with request annotation#266
Closed
darkowlzz wants to merge 1 commit intofluxcd:reconcilers-devfrom
Closed
Test reconcile with request annotation#266darkowlzz wants to merge 1 commit intofluxcd:reconcilers-devfrom
darkowlzz wants to merge 1 commit intofluxcd:reconcilers-devfrom
Conversation
This adds test for reconciliation with reconcile request annotation. Also, moves the ImagePolicy to be created per subtest, not shared anymore, to avoid interfering with other tests. Signed-off-by: Sunny <darkowlzz@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test for reconciliation with reconcile request annotation.
Since it depends on setters, it's moved as a subtest under "strategy setters".
Also, moves the ImagePolicy to be created per subtest, not shared
anymore, to avoid interfering with other tests.
Mostly based on
image-automation-controller/controllers/update_test.go
Line 264 in a582871
reconcilers-dev.