Implement core pkg/runtime/secrets migration #1846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
cappyzawa
force-pushed
the
feat-runtime-secrets-migration
branch
from
3cd259e to
e742d5a
Compare
cappyzawa
force-pushed
the
feat-runtime-secrets-migration
branch
6 times, most recently
from
d6090e9 to
4e903f7
Compare
Update pkg/runtime from v0.60.0 to v0.63.0 and migrate all secret handling to use runtime/secrets APIs directly. Key changes: - Remove wrapper functions and use runtime/secrets directly - Refactor bucket controller reconcileSource into focused functions - Update error messages to runtime/secrets v0.63.0 format - Add comprehensive tests for LoginOptionFromSecretRef - Clean up 600+ lines of redundant code and tests This establishes unified secret handling across source-controller. Signed-off-by: cappyzawa <[email protected]>
cappyzawa
force-pushed
the
feat-runtime-secrets-migration
branch
from
4e903f7 to
a1bab65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements core migration to pkg/runtime/secrets v0.63.0 for source-controller as part of fluxcd/flux2#5433.
Migrates basic auth, TLS config, and OCI registry authentication while removing internal wrapper functions.
Follow-up Work
Remaining controllers (GitRepository, HelmRepository) and cloud provider authentication will be migrated in subsequent PRs.