fix: block signals modifying the store upon startup #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for fixing #1258
Now for now I'm blocking/unblocking signals upon startup.
add_initial_tab
and widget flags from this callThese one can also change the store and are not treated yet
doc_background_pattern_color_button
doc_background_color_button
set_document_layout
calling to ->doc_document_layout_row
It also seems to me like we can either change the logic to set the initial values for the document section before the activation or setup of the handlers in
setup_doc
or change how theSignalHandlerId
variables are held to only use them once (we probably don't need to reuse them later).Seems like the unsaved indicator on startup is a little more common after the refactor on document settings as well