feat: add governed agent approval loop - #13
Merged
Merged
Conversation
fly1d
commented
Aug 11, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Second-pass code review complete: no remaining findings. The initial review identified that inactive agents could request approvals; commit 3354684 closes that gap with a fail-closed 409 response and unit, API, and container-level evidence. The store boundary, optimistic revisions, single-decision approvals, structured failures, and explicit non-production limitations are coherent. Both CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Deliver the first framework-neutral governance loop:
The bundled adapter is explicitly development-only: state is process-local and actor identity is not yet authenticated.
Evidence
make checkpasses: 22 tests, 100% coveragev1endpoints and schemas3354684: inactive agents can no longer request approvalRisk
Release notes
Added the first agent registration, lifecycle, human approval, and audit API loop.