feat: add PostgreSQL system of record - #14
Merged
Merged
Conversation
fly1d
commented
Aug 11, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Final code review completed after all required checks passed.
Findings resolved before submission:
- bare
postgresql://URLs previously selected SQLAlchemy's unavailable psycopg2 default; they now normalize to the installed psycopg 3 driver and have regression plus live-connection coverage - synchronous PostgreSQL calls previously ran inside async route handlers; store-backed routes are now synchronous so FastAPI executes them in its worker pool
No unresolved blocking findings remain in the submitted diff. The migration is reversible but destructive on downgrade, which is documented in the PR rollback plan. Authentication, idempotency, backups, retention, and tenant isolation remain explicit follow-up risks rather than hidden production claims.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACP_DATABASE_URLis unsetRisk classification
High. This introduces the first durable system of record and a reversible database migration.
Review focus
Evidence
make check: 32 passed, 1 PostgreSQL integration test skipped without a database; 98.55% coveragealembic upgrade head,alembic check, integration test,alembic downgrade base, and re-upgrade passedUPDATE,DELETE, andTRUNCATEpostgresql://andpostgresql+psycopg://URL forms use psycopg 3 successfullyRollback
alembic downgrade baseonly for disposable or explicitly approved data removal; the initial downgrade drops all control-plane tables.Remaining risks